Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent remote polling functionality from running on main poller #5170

Closed
thurban opened this issue Jan 16, 2023 · 2 comments
Closed

Prevent remote polling functionality from running on main poller #5170

thurban opened this issue Jan 16, 2023 · 2 comments
Labels
enhancement General tag for an enhancement resolved A fixed issue
Milestone
v1.2.24

Comments

@thurban
Copy link
Contributor

thurban commented Jan 16, 2023

Feature Request

Is your feature request related to a problem? Please describe

From a security perspective, functionality that is not being used should be disabled/not running. This ensures that Cacti systems that are not utilizing specific functions (i.e. Remote Poller) have a smaller risk to security issues.

Describe the solution you'd like

Functions that are specific to defined functionality should not even try to run. i.e. remote_agents.php should return if remote pollers are not used/configured.

Describe alternatives you've considered

n/a

Additional context

Add any other context or screenshots about the feature request here.
@thurban thurban added the enhancement General tag for an enhancement label Jan 16, 2023
TheWitness added a commit that referenced this issue Jan 16, 2023
@TheWitness
Fixing #5170 - More security
b350bac 
Prevent remote polling functionality from running unless remote pollers are configured
@TheWitness TheWitness added the resolved A fixed issue label Jan 16, 2023
@TheWitness TheWitness added this to the v1.2.24 milestone Jan 16, 2023
@TheWitness
Copy link
Member

Give it a review @thurban

@thurban
Copy link
Contributor Author

thurban commented Jan 16, 2023

Looks good to me. Simple but effective, so single-tier Cacti servers are save from exploits from the remote_agent.php file.

TheWitness added a commit that referenced this issue Jan 19, 2023
@TheWitness
Fixing #5170 - Deny Remote Agent
7cdb6cb 
If you only have on poller or one active poller, disable the remote agent.
TheWitness added a commit that referenced this issue Jan 22, 2023
@TheWitness
Porting #5170
5d85932
@netniV netniV changed the title Prevent remote polling functionality from running unless remote pollers are configured Prevent remote polling functionality from running on main poller Feb 15, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement General tag for an enhancement resolved A fixed issue
Projects
None yet
Milestone
v1.2.24
Development

No branches or pull requests
2 participants
@TheWitness @thurban