Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility improvements for Boost under PHP 8.x #5338

Closed
anarkia1976 opened this issue May 29, 2023 · 2 comments
Closed

Compatibility improvements for Boost under PHP 8.x #5338

anarkia1976 opened this issue May 29, 2023 · 2 comments
Labels
bug Undesired behaviour confirmed Bug is confirm by dev team porting required Requires porting to develop resolved A fixed issue
Milestone

Comments

@anarkia1976
Copy link

Hi Guys,

i have installed new cacti from scratch (release 1.2 latest source) with OS ubuntu 22.04:

OS: ubunt 22.04
PHP: 8.1.2
CACTI: 1.2 latest

i have enabled poller/boost, after this i have encountered some PHP related errors:

2023-05-29 14:35:02 - CMDPHP PHP ERROR Backtrace: (/poller_boost.php[162]:boost_prepare_process_table(), /poller_boost.php[313]:substr_count(), CactiErrorHandler())
2023-05-29 14:35:02 - ERROR PHP DEPRECATED: substr_count(): Passing null to parameter #1 ($haystack) of type string is deprecated in file: /var/www/html/cacti/poller_boost.php on line: 313
2023-05-29 14:05:01 - CMDPHP PHP ERROR Backtrace: (/poller_boost.php[131]:strtotime(), CactiErrorHandler())
2023-05-29 14:05:01 - ERROR PHP DEPRECATED: strtotime(): Passing null to parameter #1 ($datetime) of type string is deprecated in file: /var/www/html/cacti/poller_boost.php on line: 131
2023-05-29 14:05:01 - CMDPHP PHP ERROR Backtrace: (/poller_boost.php[124]:strtotime(), CactiErrorHandler())
2023-05-29 14:05:01 - ERROR PHP DEPRECATED: strtotime(): Passing null to parameter #1 ($datetime) of type string is deprecated in file: /var/www/html/cacti/poller_boost.php on line: 124

thanks a lot as always. stefano.

@anarkia1976 anarkia1976 added bug Undesired behaviour unverified Some days we don't have a clue labels May 29, 2023
@netniV
Copy link
Member

netniV commented Jun 3, 2023

Hi @anarkia1976, can you please be clear by which version you define as the latest? It may not actually be the latest.

@netniV netniV changed the title [CACTI 1.2 - latest source] PHP errors - poller boost Compatibility changes for Boost under PHP 8.1 Jun 3, 2023
TheWitness added a commit that referenced this issue Jun 3, 2023
Make this compatible with all PHP releases.
@TheWitness
Copy link
Member

This should now be fixed in a compatible way.

TheWitness added a commit that referenced this issue Jun 3, 2023
TheWitness added a commit that referenced this issue Jun 3, 2023
My goodness.  What happened?
@TheWitness TheWitness added resolved A fixed issue confirmed Bug is confirm by dev team and removed unverified Some days we don't have a clue labels Jun 3, 2023
@TheWitness TheWitness added this to the v1.2.25 milestone Jun 3, 2023
@TheWitness TheWitness added the porting required Requires porting to develop label Jun 4, 2023
@netniV netniV changed the title Compatibility changes for Boost under PHP 8.1 Compatibility improvements for Boost under PHP 8.x Sep 3, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour confirmed Bug is confirm by dev team porting required Requires porting to develop resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

3 participants