Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When a bulk walk size is set to automatic, this is not always set to the optimal value #5452

Closed
TheWitness opened this issue Aug 13, 2023 · 1 comment
Labels
bug Undesired behaviour confirmed Bug is confirm by dev team resolved A fixed issue
Milestone

Comments

@TheWitness
Copy link
Member

TheWitness commented Aug 13, 2023

Describe the bug

When the bulk walk size is set to -1, it should auto-detect, but in the latest release, the bulk_walk_size never changes from -1 to the optimum vavelue.

To Reproduce

Steps to reproduce the behavior:

  1. Update your devices to bulk walk auto-detect -1 "UPDATE host SET bulk_walk_size=-1"

  2. Force a Re-Index of all devices "poller_reindex_hosts.php --id=all --qid=all --debug"

  3. Note that the bulk_walk_size has not reset to the detected value "SELECT bulk_walk_size, count(*) AS hosts FROM host GROUP BY bulk_walk_size"

Expected behavior

Cacti should default the 'bulk_walk_size' to 0.

@TheWitness TheWitness added bug Undesired behaviour unverified Some days we don't have a clue labels Aug 13, 2023
@TheWitness TheWitness added this to the v1.2.25 milestone Aug 13, 2023
@TheWitness TheWitness added confirmed Bug is confirm by dev team question A question not a bug and removed unverified Some days we don't have a clue bug Undesired behaviour confirmed Bug is confirm by dev team labels Aug 13, 2023
@TheWitness
Copy link
Member Author

Turns out that -1 is to check the bulk walk size every polling cycle and if you set to 0, it will update to the best values on the next re-index.

@TheWitness TheWitness added the not a bug Not a bug as determined by dev label Aug 13, 2023
@TheWitness TheWitness removed this from the v1.2.25 milestone Aug 13, 2023
@TheWitness TheWitness added bug Undesired behaviour and removed question A question not a bug not a bug Not a bug as determined by dev labels Aug 13, 2023
@TheWitness TheWitness added this to the v1.2.25 milestone Aug 13, 2023
@TheWitness TheWitness changed the title When running reindexes the Cacti Device bulk walk size does not shift from -1 to the best size The default 'bulk_walk_size' is -1 which means a device will never find it's optimal bulk walk size Aug 13, 2023
@TheWitness TheWitness added the confirmed Bug is confirm by dev team label Aug 13, 2023
TheWitness added a commit that referenced this issue Aug 13, 2023
The default 'bulk_walk_size' is -1 which means a device will never find it's optimal bulk walk size
@TheWitness TheWitness added the resolved A fixed issue label Aug 13, 2023
TheWitness added a commit that referenced this issue Aug 13, 2023
The default 'bulk_walk_size' is -1 which means a device will never find it's optimal bulk walk size
@netniV netniV changed the title The default 'bulk_walk_size' is -1 which means a device will never find it's optimal bulk walk size When a bulk walk size is set to automatic, this is not always set to the optimal value Sep 3, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour confirmed Bug is confirm by dev team resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

1 participant