Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to form element warnings #5542

Closed
TheWitness opened this issue Oct 28, 2023 · 0 comments
Closed

Improvements to form element warnings #5542

TheWitness opened this issue Oct 28, 2023 · 0 comments
Labels
bug Undesired behaviour confirmed Bug is confirm by dev team resolved A fixed issue
Milestone
1.2.26

Comments

@TheWitness
Copy link
Member

Describe the bug

Reported in the Thold Bug Here: Cacti/plugin_thold#632. The issue was harder to troubleshoot as the warning message did not include the form element in question.

Expected behavior

Include the form element name to make the Plugin Developers job a bit easier to track down the warning bug in their plugin.
@TheWitness TheWitness added bug Undesired behaviour confirmed Bug is confirm by dev team labels Oct 28, 2023
@TheWitness TheWitness added this to the 1.2.26 milestone Oct 28, 2023
TheWitness added a commit that referenced this issue Oct 28, 2023
@TheWitness
Fixing #5542 - More useful warnings to plugin developers
8880b48 
When a form element does not include a 'value' column, provide a more helpful warning message
TheWitness added a commit that referenced this issue Oct 28, 2023
@TheWitness
Fixing #5542 - More useful warnings to plugin developers
a18e538 
When a form element does not include a 'value' column, provide a more helpful warning message
@TheWitness TheWitness added the resolved A fixed issue label Oct 28, 2023
@netniV netniV changed the title When a form element does not include a 'value' column, provide a more helpful warning message Improvements to form element warnings Dec 16, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Undesired behaviour confirmed Bug is confirm by dev team resolved A fixed issue
Projects
None yet
Milestone
1.2.26
Development

No branches or pull requests
1 participant
@TheWitness