On installation, allow a more appropriate template to be used as the default

[sgvfr]

Should a default device template be None instead of the top of the list?

[sgvfr]

ahh.. found in the Device defaults where it was set to ACME. on a fresh install i guess none is not the default? Changed in Configuration/Settings/Device Defaults and that did it.

[TheWitness]

Yea, we have to be smarter about this. I would frankly prefer it to be Net-SNMP Device myself.

[TheWitness]

This is fixed in both 1.2.26 and develop. If you could please re-test it would be appreciated.

[sgvfr]

This is fixed in both 1.2.26 and develop. If you could please re-test it would be appreciated.

you bet, I wrote a quick little script that creates a fresh working install in about 30 seconds.

[sgvfr]

so.. fresh install, default option for new device is still ACME. Was it supposed to ask what the user wants as a default device option?

[TheWitness]

Okay, I think the fix logic does not happen on initial install. I was going to leave the "Option" work to @netniV as he's the Installer Guru. I just wanted a hack to ensure the default is one of our 3 "preferred" for this release.

[TheWitness]

Okay, I changed it again.

[sgvfr]

Okay, I changed it again.

testing now.

[sgvfr]

Fresh install, might I be looking at this wrong? the default device doesn't seem to be getting set anywhere.

[2023-11-24 10:11:01] [          global always  ] Device Template for First Cacti Device is 18
[2023-11-24 10:11:03] [          global always  ] Creating Graphs for Default Device
[2023-11-24 10:11:03] [          global always  ] Adding Device to Default Tree
[2023-11-24 10:11:04] [          global always  ] Repopulating poller cache
[2023-11-24 10:11:04] [          global always  ] Repopulating SNMP Agent cache
[2023-11-24 10:11:06] [          global always  ] Generating RSA Key Pair
[2023-11-24 10:11:06] [          global always  ] Finished INSTALL Process for v1.3.0
[2023-11-24 10:11:07] [            sync always  ] Found 0 poller(s) to sync
[2023-11-24 10:11:07] [            sync always  ] No Remote Data Collectors found for full synchronization
[2023-11-24 10:11:07] [          global always  ] Installation was started at 2023-11-24 18:08:03, completed at 2023-11-24 18:11:07


MariaDB [cacti_devel]> select * from host_template where id=18;
+----+----------------------------------+---------------------+-------+---------+
| id | hash                             | name                | class | devices |
+----+----------------------------------+---------------------+-------+---------+
| 18 | 2d3e47f416738c2d22c87c40218cc55e | Local Linux Machine |       |       0 |
+----+----------------------------------+---------------------+-------+---------+
1 row in set (0.000 sec)

[TheWitness]

Okay, I tested it this time. I had forgotten initially to commit one additional file.

[TheWitness]

[sgvfr]

[2023-11-24 11:09:30] [ global always ] Setting the Default Device Template to 'Net-SNMP Device'

[netniV]

I've reopened this as I've rejigged the installer code. There is now a 'DefaultTemplate' parameter. At the minute, that defaults to one of the three templates listed, but ultimately, should it also take into account those templates that could already be installed?

[TheWitness]

@netniV, thanks. Marking this closed again as you have it merged to develop as well!