[1.3] QA - Error adding multiple thresholds to a device

[sgvfr]

Describe the bug
Error adding thresholds when multiple devices are selected

To Reproduce
Steps to reproduce the behavior:

1. Create a threshold for a device.
2. Assign the threshold to a device template
3. select multiple devices assigned to a template
4. choose "Apply Thresholds" and click "go"

Expected behavior
all selected devices should have the threshold created

2023-11-28 17:21:45 - PHP ERROR WARNING Backtrace: (/host.php[84]:form_actions(), /host.php[584]:form_continue_confirmation(), /lib/html_form.php[1557]:CactiErrorHandler())
2023-11-28 17:21:45 - ERROR PHP WARNING: Undefined variable $title in file: /var/www/html/cacti/lib/html_form.php on line: 1557
2023-11-28 17:21:45 - PHP ERROR WARNING Backtrace: (/host.php[84]:form_actions(), /host.php[584]:form_continue_confirmation(), /lib/html_form.php[1373]:CactiErrorHandler())
2023-11-28 17:21:45 - ERROR PHP WARNING: Undefined variable $message in file: /var/www/html/cacti/lib/html_form.php on line: 1373
2023-11-28 17:21:45 - PHP ERROR WARNING Backtrace: (/host.php[84]:form_actions(), /host.php[584]:form_continue_confirmation(), /lib/html_form.php[1327]:CactiErrorHandler())
2023-11-28 17:21:45 - ERROR PHP WARNING: Undefined array key "thold" in file: /var/www/html/cacti/lib/html_form.php on line: 1327

[TheWitness]

Which Cacti version?

[TheWitness]

This is a Cacti issue. You are using 1.3. Moving this to a Cacti issue. I'll get it fixed though.

[TheWitness]

Hey @sgvfr, this is fixed now right?

[sgvfr]

I'll check this tonight for you

[sgvfr]

Just tested withe the most current pulls.

2024-04-18 09:16:21 - PHP ERROR WARNING Backtrace: (/host.php[86]:form_actions(), /host.php[586]:form_continue_confirmation(), /lib/html_form.php[1557]:CactiErrorHandler())
2024-04-18 09:16:21 - ERROR PHP WARNING: Undefined variable $title in file: /var/www/html/cacti/lib/html_form.php on line: 1557
2024-04-18 09:16:21 - PHP ERROR WARNING Backtrace: (/host.php[86]:form_actions(), /host.php[586]:form_continue_confirmation(), /lib/html_form.php[1373]:CactiErrorHandler())
2024-04-18 09:16:21 - ERROR PHP WARNING: Undefined variable $message in file: /var/www/html/cacti/lib/html_form.php on line: 1373
2024-04-18 09:16:21 - PHP ERROR WARNING Backtrace: (/host.php[86]:form_actions(), /host.php[586]:form_continue_confirmation(), /lib/html_form.php[1327]:CactiErrorHandler())
2024-04-18 09:16:21 - ERROR PHP WARNING: Undefined array key "thold" in file: /var/www/html/cacti/lib/html_form.php on line: 1327

[TheWitness]

Thanks @sgvfr, I'll have to dig in on my 1.3 install. Been spending too much time perfecting 1.2.x over the last months.

[TheWitness]

Take a fresh snapshot and let us know how it goes. Two files host.php and lib/html_form.php

[sgvfr]

that fixed those errors, thanks!
Also likely clears the same ones from Cacti/plugin_thold#659

But two errors remain when clicking on the Thold tab / Device status (which is in the 659 issue)

2024-04-20 21:27:52 - SQL Backtrace: (/plugins/thold/thold_graph.php[104]:hosts(), /plugins/thold/thold_graph.php[956]:thold_get_allowed_devices(), /plugins/thold/thold_functions.php[7823]:db_fetch_assoc(), /lib/database.php[827]:db_fetch_assoc_prepared(), /lib/database.php[851]:db_execute_prepared())
2024-04-20 21:27:52 - CMDPHP ERROR: A DB Row Failed!, Error: Column 'graphs' in field list is ambiguous

[TheWitness]

Oh, that's a bummer.

[TheWitness]

Going to open a separate thold 1.3 QA issue for the graphs column bit. Thanks for confirming @sgvfr !

[TheWitness]

@sgvfr, fixed here: Cacti/plugin_thold#669