Remove grocer's apostrophes #2546
Conversation
There was a problem hiding this comment.
Most of these changes are in comments so have zero effect on the code (though I have made a couple of suggestions). The only code-related issue that could potentially be a problem is the changing of the name in the host_cpu.xml files in the script_query/script_server directories.
Thanks for the review and getting the language correct 👍
lib/rrd.php
Outdated
| @@ -1482,7 +1482,7 @@ function rrdtool_function_graph($local_graph_id, $rra_id, $graph_data_array, $rr | |||
| $graph_items[$j]['vdef_cache'] = $vdef; | |||
| } | |||
|
|
|||
| /* +++++++++++++++++++++++ LEGEND: TEXT SUBSTITUTION (<>'s) +++++++++++++++++++++++ */ | |||
| /* +++++++++++++++++++++++ LEGEND: TEXT SUBSTITUTION ("<>"s) +++++++++++++++++++++++ */ | |||
There was a problem hiding this comment.
Could you change lines very similar to this one so that they do not include the 's' suffix? It really isn't necessary since it is more about the text it is replacing that the plural nature of them that may be present (plus it's only a code comment)
lib/rrd.php
Outdated
|
|
||
| /* +++++++++++++++++++++++ GRAPH ITEMS: CDEF's +++++++++++++++++++++++ */ | ||
| /* +++++++++++++++++++++++ GRAPH ITEMS: CDEFs +++++++++++++++++++++++ */ |
There was a problem hiding this comment.
As an addendum to the previos comment I made, the 's' suffix on lines like this are fine where they refer to a name not piece of text to be replaced.
| Also make sure to replace all of the fancy \'s at the end of the line, | ||
| but make sure not to get rid of the "\n"'s that are supposed to be | ||
| Also make sure to replace all of the fancy "\"s at the end of the line, | ||
| but make sure not to get rid of the "\n"s that are supposed to be |
There was a problem hiding this comment.
Since you are editing the comment, can you remove the word "fancy" as it seems redundant, and maybe change the "\"s to backslashes (\) and do the same with the newline line part too.
| @@ -1,5 +1,5 @@ | |||
| <interface> | |||
| <name>Get Host MIB CPU's</name> | |||
| <name>Get Host MIB CPUs</name> | |||
There was a problem hiding this comment.
Not sure if this will cause a new input method to appear, I don't think it should be an issue but @cigamit would know better.
| @@ -1,5 +1,5 @@ | |||
| <interface> | |||
| <name>Get Host MIB CPU's</name> | |||
| <name>Get Host MIB CPUs</name> | |||
There was a problem hiding this comment.
Not sure if this will cause a new input method to appear, I don't think it should be an issue but @cigamit would know better.
https://blog.oxforddictionaries.com/2011/02/04/random-apostrophization/