When calculating percentiles, the value is incorrect as the steps are not placed in correct order #2720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The percentile calculation sorting ends up using incorrect step length due to incorrect sorting. I'm not actually 100% sure what the intended behavior here is, so I left it as sorting by step first, and steps second, though on my graphs steps seems to work just fine.
|
To clarify a bit, I have a number of graphs (incl a bunch of generic OID graphs) with one minute refresh intervals that I like having percentiles on. Many such graphs end up with bogus percentile calculation as they use percentiles over a five minute horizon average (or much, much longer) instead of over the one minute time horizon expected. This is especially visible when you have only two or so days worth of data.
… On Jun 7, 2019, at 01:02, Matt Corallo ***@***.***> wrote:
The percentile calculation sorting ends up using incorrect step length due to incorrect sorting. I'm not actually 100% sure what the intended behavior here is, so I left it as sorting by step first, and steps second, though on my graphs steps seems to work just fine.
You can view, comment on, or merge this pull request online at:
#2720
Commit Summary
Fix percentile calculation
File Changes
M lib/rrd.php (2)
Patch Links:
https://github.com/Cacti/cacti/pull/2720.patch
https://github.com/Cacti/cacti/pull/2720.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
This really should have an entry in the CHANGELOG to accompany the change but as I'm releasing today then I'll do it this time 👍 |
netniV
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The percentile calculation sorting ends up using incorrect step length due to incorrect sorting. I'm not actually 100% sure what the intended behavior here is, so I left it as sorting by step first, and steps second, though on my graphs steps seems to work just fine.