Addtional changes to allow plugin folder/display names to be handled better #3460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ddb4github
commented
Apr 14, 2020
ddb4github
commented
- plugins.php display name: info->name(<>lower(info->name)) > ucfirst(info->name) - plugin_xxx->directory is always directory name on disk.
|
Jing, can you please update the CHANGELOG please. |
|
My only issue with all these ToLower conversions is that on linux you can have muultiple copies of the same plugin causing confusion, eg, THOLD, THold, Thold would all be considered the same name. |
netniV
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.