Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When plugins update, registered files list cannot always be updated #3512

Merged
merged 2 commits into from Apr 29, 2020

Conversation

ddb4github
Copy link
Contributor

Fixed a typo in api_plugin_register_realm because all other code use , to parsing/combine realm files

Copy link
Member

@TheWitness TheWitness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jing, we need a CHANGELOG update referencing a bug. Thanks.

@TheWitness TheWitness added bug Undesired behaviour permissions Issues related to page permissions labels Apr 28, 2020
@TheWitness
Copy link
Member

We need to evaluate what might happen from this change I don't know at this point. I have to review.

@TheWitness
Copy link
Member

Okay, reviewed. This actually solves a problem. Good catch. Get the CHANGELOG updated.

@netniV netniV changed the title Fixed a typo in api_plugin_register_realm because all other code use ',' Plugin realm files can not be updated by re-register due to delimiter typo Apr 29, 2020
@netniV netniV dismissed TheWitness’s stale review April 29, 2020 13:22

Changelog applied

@netniV netniV merged commit 61b8481 into Cacti:1.2.x Apr 29, 2020
@ddb4github ddb4github deleted the fixtypo branch April 29, 2020 16:43
@netniV netniV changed the title Plugin realm files can not be updated by re-register due to delimiter typo When plugins update, registered files list cannot always be updated May 3, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour permissions Issues related to page permissions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants