Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When getting date format, default options are not always honored #4061

Merged
merged 2 commits into from Jan 18, 2021
Merged

When getting date format, default options are not always honored #4061

merged 2 commits into from Jan 18, 2021

Conversation

xmacan
Copy link
Member

@xmacan xmacan commented Jan 17, 2021

Small fix for dateformat - user defined date separator was never used

netniV
netniV reviewed Jan 17, 2021
View reviewed changes
Copy link
Member

@netniV netniV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't read_user_setting already use read_config_option to attempt a default ? The reason for the if statement was to ensure something was set

@xmacan
Copy link
Member Author

xmacan commented Jan 17, 2021

read_user_setting

Doesn't read_user_setting already use read_config_option to attempt a default ? The reason for the if statement was to ensure something was set

read_user_setting uses only read_default_user_setting (or I'm blind :-)

@TheWitness
Copy link
Member

Need a CHANGELOG update

@TheWitness
Copy link
Member

Second option is default, third I think is force.

@TheWitness TheWitness merged commit b3409b3 into Cacti:1.2.x Jan 18, 2021
@jav4 jav4 mentioned this pull request Jan 21, 2021
Closed
@netniV netniV changed the title Fix dateformat in graph When getting date format, default options are not always honored Apr 12, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jul 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@netniV netniV netniV left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xmacan @TheWitness @netniV