Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing #4284 - Parameters in array_key_exists (1.2.17 database upgrade) #4285

Merged
merged 4 commits into from Jun 5, 2021
Merged

Fixing #4284 - Parameters in array_key_exists (1.2.17 database upgrade) #4285

merged 4 commits into from Jun 5, 2021

Conversation

mchorsley
Copy link
Contributor

Three parameters passed to array_key_exists function in 1_2_17.php. Removed rogue third parameter.

netniV
netniV requested changes May 29, 2021
View reviewed changes
Copy link
Member

@netniV netniV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the submission. We appreciate it.

Fix itself looks good, but can you add a CHANGELOG entry with a matching title to the issue it's fixing?

I would also suggest updating the title to be something more 'plain English' rather than tech speaking.

netniV
netniV reviewed Jun 3, 2021
View reviewed changes
CHANGELOG Outdated Show resolved Hide resolved
@netniV netniV merged commit 5a53ffc into Cacti:1.2.x Jun 5, 2021
@netniV
Copy link
Member

netniV commented Jun 5, 2021

It's all good. Allowed me to fix up where I put a changelog item as mine was in the wrong place too :)

@mchorsley mchorsley deleted the 1.2.x branch June 8, 2021 11:47
@github-actions github-actions bot locked and limited conversation to collaborators Sep 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@netniV netniV netniV requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mchorsley @netniV