When passed a null value, number_format_i18n() can return a invalid number #5136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a CHANGELOG entry? |
|
We will also need to apply this to develop |
ddb4github
force-pushed
the
fix_number_format_i18n
branch
from
ac8c9bb
to
3f7dc3b
Compare
netniV
approved these changes
Jan 6, 2023
|
This commit should now be cherry picked to develop or committed as a new change there if it doesn't already apply. |
ddb4github
added a commit
to ddb4github/cacti
that referenced
this pull request
Jan 14, 2023
netniV
changed the title
netniV
changed the title
netniV
added
bug
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed: functiom number_format_i18n should return a valid number '0' for NULL input