Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When disabling a user, no log is recorded #5209

Merged
merged 2 commits into from Feb 1, 2023

Conversation

xmacan
Copy link
Member

@xmacan xmacan commented Jan 31, 2023

please at least think about this change. Recently I couldn't log in and couldn't quickly figure out it was a disabled account

@TheWitness
Copy link
Member

Could you add a changelog?

@TheWitness TheWitness merged commit bc58fbc into Cacti:develop Feb 1, 2023
@xmacan
Copy link
Member Author

xmacan commented Feb 1, 2023

@netniV will be applied to 1.2.x or not?

@netniV
Copy link
Member

netniV commented Feb 1, 2023

I don't see a reason we can't back port this. The $error line seems pointless slow though.

TheWitness added a commit that referenced this pull request Feb 5, 2023
Add account disable log message for disabled users attempting to login
@TheWitness
Copy link
Member

Okay, this is backported now.

@netniV netniV changed the title add account disable log message When disabling a user, no log is recorded Feb 15, 2023
@netniV netniV added bug Undesired behaviour resolved A fixed issue confirmed Bug is confirm by dev team labels Feb 15, 2023
@netniV netniV added this to the v1.2.24 milestone Feb 15, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour confirmed Bug is confirm by dev team resolved A fixed issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants