Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional security to the unserialize function #5245

Merged
merged 20 commits into from
Feb 24, 2023
Merged

Add additional security to the unserialize function #5245

merged 20 commits into from
Feb 24, 2023

Commits on Feb 16, 2023

  1. Fixing #5238 - SQL Issues due to non-visible chars

    Searching for Poller Items Generates SQL Errors
    TheWitness committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    e64a16a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e3284bf View commit details
    Browse the repository at this point in the history
  3. Fixing #5232 Poller Stacking

    * On large systems statistics gathering at the beginning of a poller run lead to excessive polling times
    * It's important to remove all items from the poller_output table for the poller as it impacts the end of the previous poller
    * The other change here has to do with large databases where the poller_output memory table can get pushed into swap.
    * Moved statistics out of the internal loop, and made a few optimizations for the $totals query to perform better.
    * We only care about total_ports if the snmp_port is > 0
    TheWitness committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    0117c71 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2023

  1. Configuration menu
    Copy the full SHA
    d96d8a6 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2023

  1. QA on #5238 - Disable for multiple pollers

    This is a compromise with regard to a possible issue with MariaDB 10.3 to only allow this via setting, and only allow for single poller systems.
    
    We will look to re-design this in a future Cacti release.
    TheWitness committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    6622b99 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2023

  1. Configuration menu
    Copy the full SHA
    9ff40a3 View commit details
    Browse the repository at this point in the history
  2. QA: Automation incorrectly creates graphs

    This test added multi-output values that return a NaN or 'U'.
    TheWitness committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    7e255bc View commit details
    Browse the repository at this point in the history
  3. Fixing #5236 - Edit Graph Template

    Edit Graph Template link missing base_url.
    TheWitness committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    00216a8 View commit details
    Browse the repository at this point in the history
  4. Fixing #5243 - Export columns missing

    Template Export missing Graph Template columns multiple and test_source
    TheWitness committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    56fa967 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2023

  1. QA: Add additional security to the unserialize function

    * This change will add additional security to prevent certain classes of exploits in Cacti's use of the unserialize function.
    * Additionally, adding an additional setting to dsv_log() to reduce the amount of logging during use of the tool to test data sources vs. poller operations.
    TheWitness committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    9df63c4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0769e36 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1947429 View commit details
    Browse the repository at this point in the history
  4. Fixing Issue #5239 - Automation SNMP Bulk Size

    * SNMP-Options - Bulk Walk Maximum Repetitions ignored during save
    * light PSR to remove tabs and replace with spaces.
    TheWitness committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    3eb3efa View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7e2abb8 View commit details
    Browse the repository at this point in the history
  6. Fixing #5241 - Polling distribution not working

    "Balance Process Load" dont work after upgrade to 1.2.23
    TheWitness committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    10ae8d9 View commit details
    Browse the repository at this point in the history
  7. Fixing #5247 and QA on #5241 - Polling Issues

    * Rebuilding Poller Cache from Utilities does not respect poller interval due to lack or ordering
    * Decrementing of rrd_next_step is flawed
    TheWitness committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    17bcbcc View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2023

  1. Configuration menu
    Copy the full SHA
    7ab5b8e View commit details
    Browse the repository at this point in the history
  2. Remove unused call

    TheWitness committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    6f4d854 View commit details
    Browse the repository at this point in the history
  3. QA: Two issues reported by users

    * We still have references in the code to 'poller_lastrun' without the poller id.  Set the legacy value if the poller_id is 1
    * If the poller_interval equals the cron interval, you can still have to bypass the scalability enhancement if you largest data source profile is larger than the poller interval
    TheWitness committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    b7008e8 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1207e63 View commit details
    Browse the repository at this point in the history