Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a dockerfile #1037

Closed
wants to merge 1 commit into from
Closed

Add a dockerfile #1037

wants to merge 1 commit into from

Conversation

roipoussiere
Copy link

@roipoussiere roipoussiere commented Mar 30, 2022

I created a dockerfile for cadquery (here on docker hub). This is an easy way to try cq without having to install Conda.

Does it make sense for you to add it to this repo?

Usage

Let's suppose we have the following script:

import cadquery as cq
box = cq.Workplane("XY").box(1, 2, 3)
print(box.toSvg())

You can generate the svg with:

docker run -i --rm cadquery/cadquery python < ./box.py > box.svg

If you need more control to your project (installing Python dependencies, use external files, etc), you can create a docker volume:

docker run --rm -it -v $(pwd)/examples:/home/cq cadquery/cadquery

It will open a shell prompt on which you can work.

@jmwright
Copy link
Member

jmwright commented Apr 2, 2022

@roipoussiere Can you merge master into your branch? There was a very recent change that should fix the AppVeyor failure.

@codecov
Copy link

codecov bot commented Apr 2, 2022

Codecov Report

Merging #1037 (a55af4d) into master (3f6da6d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1037   +/-   ##
=======================================
  Coverage   96.32%   96.32%           
=======================================
  Files          40       40           
  Lines        9405     9405           
  Branches     1248     1248           
=======================================
  Hits         9059     9059           
  Misses        204      204           
  Partials      142      142           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@adam-urbanczyk
Copy link
Member

@roipoussiere could you add some kind of simple test?

@roipoussiere
Copy link
Author

What kind?

If you CI runs on docker, it's not trivial to test the dockerfile because it would require to run docker on docker.

@adam-urbanczyk
Copy link
Member

Simple smoke test would be fine - build the image and verify that it runs.

@roipoussiere
Copy link
Author

Now we have the ocp-vtk wheel, a cadquery docker image seem not really necessary, so I'm going to close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants