Update docstring, use fluent api + stringselector #1079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the docstring for `shell` to use the string selector and fluent api to show how to create a three faced cube. Remove the note about shelling being a common use case for `Workplane.add`
Codecov Report
@@ Coverage Diff @@
## master #1079 +/- ##
=======================================
Coverage 96.32% 96.32%
=======================================
Files 40 40
Lines 9427 9427
Branches 1251 1251
=======================================
Hits 9081 9081
Misses 204 204
Partials 142 142
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
jmwright
approved these changes
May 6, 2022
|
@lorenzncode It looks like you've approved this PR. Feel free to merge if you feel this PR is ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the docstring for
shellto use the string selector and fluentapi to show how to create a three faced cube.
Remove the note about shelling being a common use case for
Workplane.addFixes #828