Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better build string #1315

Merged
merged 1 commit into from
Apr 16, 2023
Merged

Better build string #1315

merged 1 commit into from
Apr 16, 2023

Conversation

adam-urbanczyk
Copy link
Member

@adam-urbanczyk adam-urbanczyk commented Apr 16, 2023 •
edited
Loading

Allows to identify master builds

@codecov
Copy link

codecov bot commented Apr 16, 2023 •
edited
Loading

Codecov Report

Merging #1315 (8a84918) into master (e28d94c) will not change coverage.
The diff coverage is n/a.

❗ Current head 8a84918 differs from pull request most recent head 4a8c33a. Consider uploading reports for the commit 4a8c33a to get more accurate results

@@           Coverage Diff           @@
##           master    #1315   +/-   ##
=======================================
  Coverage   94.24%   94.24%           
=======================================
  Files          26       26           
  Lines        5495     5495           
  Branches      932      932           
=======================================
  Hits         5179     5179           
  Misses        187      187           
  Partials      129      129

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

lorenzncode
lorenzncode approved these changes Apr 16, 2023
View reviewed changes
Copy link
Member

@lorenzncode lorenzncode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - better than the 'py_0' string.

jmwright
jmwright approved these changes Apr 16, 2023
View reviewed changes
Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adam-urbanczyk

@jmwright jmwright merged commit 3b9ead1 into master Apr 16, 2023
@adam-urbanczyk adam-urbanczyk mentioned this pull request Dec 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmwright jmwright jmwright approved these changes

@lorenzncode lorenzncode lorenzncode approved these changes

Assignees
No one assigned
Labels
infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adam-urbanczyk @jmwright @lorenzncode