Fix findSolid if multiple solids present on the stack #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #163 +/- ##
=========================================
+ Coverage 94.79% 94.8% +0.01%
=========================================
Files 19 19
Lines 4092 4101 +9
=========================================
+ Hits 3879 3888 +9
Misses 213 213
Continue to review full report at Codecov.
|
|
@jmwright could you take a look? I think it is correct, but did not really do extensive testing. |
|
@adam-urbanczyk I think it looks ok. Is there a test(s) that we could add for this? |
jmwright
approved these changes
Jul 12, 2019
|
@jmwright I added one test. Feel free to merge if you agree and CI passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will resolve #159