-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
occ_impl
doc strings
#491
occ_impl
doc strings
#491
Conversation
Before I get too far I thought I should just check, these methods don't have doc strings because no one has got around to it yet, correct? Not because they are supposed to be hidden from users or sphinx? Or because the OCCT docs are supposed to be the only source and we don't want to repeat this stuff in CQ? edit: For example, |
Codecov Report
@@ Coverage Diff @@
## master #491 +/- ##
=======================================
Coverage 93.65% 93.65%
=======================================
Files 30 30
Lines 5881 5881
Branches 626 626
=======================================
Hits 5508 5508
Misses 234 234
Partials 139 139
Continue to review full report at Codecov.
|
55960c9
to
90749e6
Compare
I tried to squash commits and something went horribly wrong. Successfully squashed with that second force push now. |
I'm done for now. If I'm feeling masochistic again I'll try to do some more in another PR. |
Thanks @marcus7070 - I think it was due to all of the above reasons. |
90749e6
to
202b8af
Compare
Ok then, if there are reasons to not have doc strings on any of these methods then please do remove them from this PR or reject it entirely. I don't mind; I did the work to familiarise myself with the methods, it's not wasted effort. |
Thanks @marcus7070 , I think we should merge it before 2.1. In the end it does not hurt to have better docstrings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than my comment, this is ready to merge. Thanks @marcus7070
Merging, thanks @marcus7070 . |
I've realised that there are a few useful methods in the
occ_impl
layer that I wasn't familar with. So I'm going through and adding docstrings to a few and fixing any inconsistent formatting or other small things I see.