better snapshot and fix markdown in notification plain text #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have mutlicam support ready if this is merged, since the code is based on the changes here. https://github.com/Links2004/octoprint-matrix-notifier-plugin/tree/multicam |
|
Thanks a lot for the contribution! The fact that there isn't a way to get the image with the correct metadata from upstream seems pretty wild. |
Cadair
reviewed
Dec 27, 2021
Cadair
reviewed
Dec 27, 2021
Cadair
reviewed
Dec 27, 2021
octoprint_matrix_notifier/plugin.py
Outdated
Comment on lines
294
to
297
| def take_image(self, snapshot_url=""): | ||
| if snapshot_url == "": | ||
| snapshot_url = self._settings.global_get(["webcam", "snapshot"]) | ||
| if snapshot_url == "": |
There was a problem hiding this comment.
I think this is a little cleaner:
Suggested change
| def take_image(self, snapshot_url=""): | |
| if snapshot_url == "": | |
| snapshot_url = self._settings.global_get(["webcam", "snapshot"]) | |
| if snapshot_url == "": | |
| def take_image(self, snapshot_url=None: | |
| if not snapshot_url: | |
| snapshot_url = self._settings.global_get(["webcam", "snapshot"]) | |
| if not snapshot_url: |
There was a problem hiding this comment.
update the branch with the multicam support changes which refactor this place ;)
Co-authored-by: Stuart Mumford <stuart@cadair.com>
This was referenced Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #12, #7