Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change ensure_future to create_task #61

Closed
Cadair opened this issue Dec 18, 2020 · 5 comments
Closed

Change ensure_future to create_task #61

Cadair opened this issue Dec 18, 2020 · 5 comments
Labels
enhancement A new feature or other enhancement to the library good first issue

Comments

@Cadair
Copy link
Owner

Cadair commented Dec 18, 2020

https://docs.python.org/3/library/asyncio-task.html#asyncio.create_task

we can do this because we are now 3.7+
@Cadair Cadair mentioned this issue Dec 18, 2020
Closed
@Cadair Cadair added enhancement A new feature or other enhancement to the library good first issue labels Dec 18, 2020
@1nF0rmed
Copy link
Contributor

Hey!
Can I be assigned this task?

@Cadair
Copy link
Owner Author

Cadair commented Dec 18, 2020

You are welcome to work on it, I generally don't assign people to things though :)

@1nF0rmed
Copy link
Contributor

Is assigning issues frowned upon? I was told the same in a previous issue

1nF0rmed added a commit to 1nF0rmed/parfive that referenced this issue Dec 18, 2020
@1nF0rmed
Fixes Cadair#61
48dd679
@1nF0rmed
Copy link
Contributor

Hey I've made a PR #62

@Cadair
Copy link
Owner Author

Cadair commented Dec 18, 2020

it's just a workflow choice some people and teams use it others don't. Sunpy and my personal repos generally don't unless there is a specific reason to.

@Cadair Cadair closed this as completed in 3c79366 Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement A new feature or other enhancement to the library good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Cadair @1nF0rmed