Do not deprecate header kwarg to Downloader #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cadair
force-pushed
the
no_deprecation_only_zuul
branch
from
ef3b509
to
424c9c6
Compare
Full API break in 2.0 incoming
Cadair
force-pushed
the
no_deprecation_only_zuul
branch
from
424c9c6
to
bd312c2
Compare
Codecov Report
@@ Coverage Diff @@
## main #101 +/- ##
==========================================
- Coverage 93.55% 93.40% -0.16%
==========================================
Files 5 5
Lines 559 546 -13
==========================================
- Hits 523 510 -13
Misses 36 36
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.