Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup after Keyboard interrupt correctly #104

Merged
merged 8 commits into from
Jul 1, 2022
Merged

Cleanup after Keyboard interrupt correctly #104

merged 8 commits into from
Jul 1, 2022

Conversation

Cadair
Copy link
Owner

@Cadair Cadair commented Jun 29, 2022

Fixes #60

@codecov
Copy link

codecov bot commented Jun 29, 2022

Codecov Report

Merging #104 (b3d52d5) into main (ceaa210) will decrease coverage by 2.35%.
The diff coverage is 70.66%.

@@            Coverage Diff             @@
##             main     #104      +/-   ##
==========================================
- Coverage   93.13%   90.77%   -2.36%     
==========================================
  Files           5        5              
  Lines         568      607      +39     
==========================================
+ Hits          529      551      +22     
- Misses         39       56      +17     
Impacted Files Coverage Δ
parfive/main.py 91.17% <0.00%> (-2.77%) ⬇️
parfive/utils.py 90.51% <25.00%> (-4.03%) ⬇️
parfive/downloader.py 90.35% <78.46%> (-2.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ceaa210...b3d52d5. Read the comment docs.

@Cadair Cadair merged commit 1e802fe into main Jul 1, 2022
@Cadair Cadair deleted the fix_interrupt branch July 1, 2022 15:58
@Cadair Cadair changed the title Add SIGINT handling Cleanup after Keyboard interrupt correctly Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

keyboard interrupt does not kill the download loop cleanly
1 participant