Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not overwrite custom headers if user agent isn't specified #89

Merged
merged 1 commit into from
Jun 9, 2022

Conversation

Cadair
Copy link
Owner

@Cadair Cadair commented Jun 9, 2022

Fixes #85

@Cadair Cadair added the bug A report of or a fix for a bug or unwanted behaviour label Jun 9, 2022
@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #89 (07ff582) into main (8652805) will increase coverage by 0.15%.
The diff coverage is n/a.

❗ Current head 07ff582 differs from pull request most recent head 5ca4c56. Consider uploading reports for the commit 5ca4c56 to get more accurate results

@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
+ Coverage   91.82%   91.98%   +0.15%     
==========================================
  Files           4        4              
  Lines         477      474       -3     
==========================================
- Hits          438      436       -2     
+ Misses         39       38       -1     
Impacted Files Coverage Δ
parfive/downloader.py 95.57% <ø> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ce3935...5ca4c56. Read the comment docs.

@Cadair Cadair merged commit 4bb425c into main Jun 9, 2022
@Cadair Cadair deleted the headers_ua_fix branch June 9, 2022 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A report of or a fix for a bug or unwanted behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User specified headers are ignored if User-Agent isn't specified
1 participant