Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use pydantic for settings validation #98

Merged
merged 6 commits into from
Jun 23, 2022
Merged

Do not use pydantic for settings validation #98

merged 6 commits into from
Jun 23, 2022

Conversation

Cadair
Copy link
Owner

@Cadair Cadair commented Jun 22, 2022

@SolarDrew found an issue with pydantic where you couldn't pass the SSL Context into aiohttp_session_kwargs, I couldn't figure it out so I gave up

@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #98 (2e18740) into main (f3dac92) will increase coverage by 0.22%.
The diff coverage is 100.00%.

❗ Current head 2e18740 differs from pull request most recent head f8c2370. Consider uploading reports for the commit f8c2370 to get more accurate results

@@            Coverage Diff             @@
##             main      #98      +/-   ##
==========================================
+ Coverage   93.33%   93.55%   +0.22%     
==========================================
  Files           5        5              
  Lines         540      559      +19     
==========================================
+ Hits          504      523      +19     
  Misses         36       36              
Impacted Files Coverage Δ
parfive/config.py 99.07% <100.00%> (+0.19%) ⬆️
parfive/downloader.py 93.26% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3dac92...f8c2370. Read the comment docs.

@Cadair Cadair added the misc Small internal changes or updates label Jun 22, 2022
@Cadair Cadair changed the title Sorry pydantic Do not use pydantic for settings validation Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
misc Small internal changes or updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant