Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I made this change
If you add or edit a party on the platform and leave non-required fields blank, number and date fields , which are blank, are displayed as None.
The
render
method of each attribute simply returns the value passed to theval
parameter; forNone
values this results in "None" being displayed.Description of the change
If the provided value is
None
return an empty string (''
)How someone else can test the change
Install this branch in the platform.
Create a project using this form. The form contains an
integer
field callednumber_children
and adate
field calleddob
.Create a party, choose the party type "Individual" leave both
number_children
anddob
blank. After saving you should check on the party detail page that no value is displayed for both fields.When should this PR be merged
This is somewhat urgent to one partner so we need to get it through quickly.
Risks
None
Follow-up actions