Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Editor] Fixed issue where editor mods did not get removed #274

Merged
merged 22 commits into from Aug 8, 2023

Conversation

shoushou1106
Copy link
Contributor

@shoushou1106 shoushou1106 commented Aug 2, 2023

This error happens occasionally, the probability is very small but I encountered it(at 1.0.6.2).
I'm a new programmer, my English is not good, if i don't do well just ignore it, sorry for bothering.
Also, please open for issue, users don’t know how to report bugs at all

FrostyEditor/Windows/MainWindow.xaml.cs Outdated Show resolved Hide resolved
FrostyEditor/Windows/MainWindow.xaml.cs Outdated Show resolved Hide resolved
FrostyEditor/Windows/MainWindow.xaml.cs Outdated Show resolved Hide resolved
@Dyvinia
Copy link
Contributor

Dyvinia commented Aug 3, 2023

i just think itd be better to check for editor mods when launching and just delete them, so like 1-2 lines of code total

@wannkunstbeikor
Copy link
Collaborator

i just think itd be better to check for editor mods when launching and just delete them, so like 1-2 lines of code total

u would still need to delete the mods.json, since that stores the names of the prev mods, and if those are the same for some reason it will not regenerate

@shoushou1106 shoushou1106 changed the title [Editor & ModSupport] Fix BUG: Editor launch game will retain the last edit [Editor] Fix BUG: Editor launch game will retain the last edit Aug 3, 2023
also fix a ui bug in prelaunchwindow
@shoushou1106
Copy link
Contributor Author

shoushou1106 commented Aug 3, 2023

i just think itd be better to check for editor mods when launching and just delete them, so like 1-2 lines of code total

i think it would be better to delete the mods.json file in the editor than adding this boolean to the run method

OK, I did it both
Also fix a little UI bug in PrelaunchWindow2.xaml.cs

FrostyEditor/Windows/MainWindow.xaml.cs Outdated Show resolved Hide resolved
FrostyModSupport/FrostyModExecutor.cs Outdated Show resolved Hide resolved
@wannkunstbeikor
Copy link
Collaborator

@Dyvinia pls look over this again, is the issue u mentioned fixed?

@shoushou1106
Copy link
Contributor Author

shoushou1106 commented Aug 6, 2023

there still needs to be modPaths.Add() for any other mods

uh, is there still any problem with it?

@shoushou1106 shoushou1106 changed the title [Editor] Fix BUG: Editor launch game will retain the last edit [Editor] Fix BUG: EditorMod will retain when Editor crash at launch Aug 7, 2023
@shoushou1106 shoushou1106 changed the title [Editor] Fix BUG: EditorMod will retain when Editor crash at launch [Editor & ModSupport] Fix BUG: EditorMod remains & ModData destroyed if Frosty crashes when launching the game Aug 7, 2023
@shoushou1106 shoushou1106 changed the title [Editor & ModSupport] Fix BUG: EditorMod remains & ModData destroyed if Frosty crashes when launching the game [Editor & ModSupport] Fix BUG: EditorMod remains if Frosty crashes when launching the game Aug 7, 2023
@wannkunstbeikor wannkunstbeikor merged commit d0e9a65 into CadeEvs:1.0.6.3 Aug 8, 2023
@shoushou1106 shoushou1106 changed the title [Editor & ModSupport] Fix BUG: EditorMod remains if Frosty crashes when launching the game [Editor] Fixed issue where editor mods did not get removed Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants