Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve CI #5

Merged
merged 6 commits into from
Apr 3, 2020
Merged

Improve CI #5

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
339a4fa
Update nodejs.yml
CadenGjy Apr 3, 2020
93ecf2f
Update nodejs.yml
CadenGjy Apr 3, 2020
8529a33
Update nodejs.yml
CadenGjy Apr 3, 2020
32c2e0d
Update .github/workflows/nodejs.yml
CadenGjy Apr 3, 2020
c355d99
Update .github/workflows/nodejs.yml
CadenGjy Apr 3, 2020
edc5259
Update .github/workflows/nodejs.yml
CadenGjy Apr 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/nodejs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:

strategy:
matrix:
node-version: [10.x, 12.x]
node-version: [8.x, 10.x]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Step 8: Target a Windows environment

Since we'd like to support deploying our app to Windows environments, let's add Windows to the matrix build configuration.

⌨️ Activity: Edit your workflow file to build for Windows environments

You can follow the suggestion, or manually make the changes in the numbered instructions.

Suggested change
node-version: [8.x, 10.x]
os: [ubuntu-lastest, windows-2016]
node-version: [8.x, 10.x]
  1. Edit the workflow config at .github/workflows/nodejs.yml
  2. Add an os field to the strategy.matrix section of your workflow
  3. Add ubuntu-latest and windows-2016 to the target operating systems
  4. Commit your workflow changes to this branch.

I'll respond in this pull request when you've committed.


steps:
- uses: actions/checkout@v2
Expand Down