Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve CI #5
Improve CI #5
Changes from 5 commits
339a4fa
93ecf2f
8529a33
32c2e0d
c355d99
edc5259
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Step 8: Target a Windows environment
Since we'd like to support deploying our app to Windows environments, let's add Windows to the matrix build configuration.
⌨️ Activity: Edit your workflow file to build for Windows environments
You can follow the suggestion, or manually make the changes in the numbered instructions.
.github/workflows/nodejs.yml
os
field to thestrategy.matrix
section of your workflowubuntu-latest
andwindows-2016
to the target operating systemsI'll respond in this pull request when you've committed.