Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concurrency issues #2

Closed
MiniDigger opened this issue May 4, 2020 · 3 comments · Fixed by #9
Closed

Concurrency issues #2

MiniDigger opened this issue May 4, 2020 · 3 comments · Fixed by #9
Assignees
Labels
bug Something isn't working

Comments

@MiniDigger
Copy link
Member

atlas has threading problems it seems. Its running into concurrent modification exceptions for getOrCreateClass on a mapping set
putting a synchronized(remapper) into the JarEntryRemappingTransformer solves it
was wondering why I was randomly missing classes, somewhere the exception gets eaten too

@jamierocks jamierocks added the bug Something isn't working label May 4, 2020
jamierocks added a commit that referenced this issue May 4, 2020
This addresses one of the issues raised in GH-2.
jamierocks added a commit that referenced this issue May 4, 2020
This addresses one of the issues raised in GH-2.
@jamierocks jamierocks self-assigned this Sep 11, 2020
@jamierocks
Copy link
Member

I believe this has been sufficiently resolved in Lorenz, for that use case. Perhaps its a good idea to allow consumers to use a single-threaded mode so that all can use Atlas.

@jamierocks
Copy link
Member

Perhaps its a good idea to allow consumers to use a single-threaded mode so that all can use Atlas.

The plan is to allow configurable parallelism, similar to CadixDev/Lorenz@84ca071.

jamierocks added a commit that referenced this issue Jan 30, 2021
This addresses one of the issues raised in GH-2.
@jamierocks jamierocks linked a pull request Jan 30, 2021 that will close this issue
@jamierocks
Copy link
Member

Atlas 0.2.1 should resolve all concerns here: you can effectively run Atlas in a single-threaded mode, and exceptions will no longer be 'eaten' during transformation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants