Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI size limited to 4 #259

Closed
MeeniMc opened this issue Aug 15, 2020 · 14 comments
Closed

GUI size limited to 4 #259

MeeniMc opened this issue Aug 15, 2020 · 14 comments
Labels
T-enhancement Type: Enhancement

Comments

@MeeniMc
Copy link
Contributor

MeeniMc commented Aug 15, 2020

Is your feature request related to a problem? Please describe.
Yes, GUI size is limited to 4, it can be set to much larger values in Vanilla MC.

Describe the solution you'd like
GUI size can be set to a large value.

Describe alternatives you've considered
Disabling Sodium, setting the gui size with the vanilla interface, and then reloading Sodium lets one select the GUI size, but that is not ideal. However if one touches the gui size slider, then it is not possible to reset it to a larger than 4 value.

Workaround

In the Sodium Options screen, use shift-p keybinding to change the gui scale using the Vanilla Video Options screen.

@MeeniMc MeeniMc added the T-enhancement Type: Enhancement label Aug 15, 2020
@Madis0
Copy link
Contributor

Madis0 commented Aug 15, 2020

Just wondering, does vanilla actually show numbers higher than 4 or does it just upscale it to the max when set to auto?

@amnotbananaama amnotbananaama added the S-info-needed Status: Info needed label Aug 25, 2020
@amnotbananaama
Copy link
Contributor

Can you explain how you are setting the GUI scale to values larger than 4 in Vanilla? According to the Minecraft wiki, the only valid values for guiScale are 0-4.

If I edit the options.txt file to an arbitrary guiScale value (let's say 5), both Vanilla and Sodium load and parse that option. I don't have access to a large enough display to test, can you share screenshots comparing guiScale 5 vs guiScale 4?

@abouteiller
Copy link

2020-08-27_03 08 49
Fullscreen on a 4k screen. Clicking the button cycles 1-9-Auto. In windowed mode it cycles 1-4-Auto.

@amnotbananaama amnotbananaama removed the S-info-needed Status: Info needed label Aug 30, 2020
@amnotbananaama
Copy link
Contributor

So under this enhancement would Sodium just increase the max GUI scale to 9? I’m not sure what the maximum GUI size should be, we need to specify some limit.

@MeeniMc
Copy link
Contributor Author

MeeniMc commented Aug 30, 2020

Looks correct. That's what the Vanilla config does.

@silversquirl
Copy link
Member

Vanilla appears to change the maximum value based on the size of the window (or the screen resolution in full screen). Perhaps Sodium could implement something similar.

@nisutec
Copy link

nisutec commented Dec 28, 2020

Hello,
Is a fix for this problem current under development.

@ImperatorStorm
Copy link
Contributor

no

@nisutec
Copy link

nisutec commented Dec 28, 2020

Ok but the workaround works thx

@Seegras
Copy link

Seegras commented Apr 4, 2021

This is a problem on 4k where the GUI is either way too big, or much too small (I use 6 for a near "auto on 1080p"-feeling)

Especially when streaming or doing videos, where you want to have big bold GUI, but one that still does show everything with no overlapping elements.

MeeniMc pushed a commit to MeeniMc/sodium-fabric that referenced this issue Apr 5, 2021
…f using a fixed value of 4 for the maximum GUI scale in the Sodium options page, the auto GUI scale (largest calculated size) will be used. Allowing the GUI scale to extend above 4 is helpful on high-dpi displays, where significantly larger GUI scales are necessary to match the physical size of equivalent low-dpi displays. This matches vanilla behavior and fixes CaffeineMC#259.

Original work by Bytzo, updated for Sodium-next by MeeniMc
MeeniMc pushed a commit to MeeniMc/sodium-fabric that referenced this issue Apr 5, 2021
…f using a fixed value of 4 for the maximum GUI scale in the Sodium options page, the auto GUI scale (largest calculated size) will be used. Allowing the GUI scale to extend above 4 is helpful on high-dpi displays, where significantly larger GUI scales are necessary to match the physical size of equivalent low-dpi displays. This matches vanilla behavior and fixes CaffeineMC#259.

Original work by @bytzo, updated for Sodium-next by @MeeniMc
MeeniMc added a commit to MeeniMc/sodium-fabric that referenced this issue Apr 5, 2021
…f using a fixed value of 4 for the maximum GUI scale in the Sodium options page, the auto GUI scale (largest calculated size) will be used. Allowing the GUI scale to extend above 4 is helpful on high-dpi displays, where significantly larger GUI scales are necessary to match the physical size of equivalent low-dpi displays. This matches vanilla behavior and fixes CaffeineMC#259.

Original work by @bytzo, updated for Sodium-next by @MeeniMc
@0AA55H
Copy link

0AA55H commented Jan 28, 2022

I just write to confirm that editing/setting guiScale to 6 in options.txt works. Just tested on Minecraft 1.18.1 with fabric/sodium and 4k. BTW, my monitor is 1920x1200, but i use nvidia DSR factors to force the game to render in 4K and then it is downsampled to native resolution. This puts a lot of pressure on the GPU of course, but the result is fantastic 😊

FlashyReese added a commit to FlashyReese/sodium-extra-fabric that referenced this issue Jan 28, 2022
Instead of using a fixed value of 4 for the maximum GUI scale in the Sodium options page, the largest calculated GUI scale (auto) will be used. This matches vanilla behavior and fixes CaffeineMC/sodium-fabric#259.
FlashyReese added a commit to FlashyReese/sodium-extra-fabric that referenced this issue Jan 28, 2022
Instead of using a fixed value of 4 for the maximum GUI scale in the Sodium options page, the largest calculated GUI scale (auto) will be used. This matches vanilla behavior and fixes CaffeineMC/sodium-fabric#259.
FlashyReese added a commit to FlashyReese/sodium-extra-fabric that referenced this issue Jan 28, 2022
Instead of using a fixed value of 4 for the maximum GUI scale in the Sodium options page, the largest calculated GUI scale (auto) will be used. This matches vanilla behavior and fixes CaffeineMC/sodium-fabric#259.
FlashyReese added a commit to FlashyReese/sodium-extra-fabric that referenced this issue Jan 28, 2022
Instead of using a fixed value of 4 for the maximum GUI scale in the Sodium options page, the largest calculated GUI scale (auto) will be used. This matches vanilla behavior and fixes CaffeineMC/sodium-fabric#259.
@MeeniMc
Copy link
Contributor Author

MeeniMc commented Feb 9, 2022

pr #1013

@aschoettler
Copy link

aschoettler commented Feb 24, 2022

Like many people, I occasionally play Minecraft on my laptop. But I also sometimes play using an external monitor. I have a "retina" macbook pro which has a 2880x1800 resolution display on a 15-inch screen. On the external monitor I use guiScale 3 but I would like to see GUI scale options that go above 4 on my laptop since the gui elements are too small for me to see clearly at that scale. This is all to emphasize that I believe anyone using sodium on a macbook pro made in the last 7ish years may be affected by this issue.

The best workaround I have found is to manually open options.txt in a text editor and change guiScale to 5. This prevents having to launch the client 3 times per sitting (as in the other workaround), reducing it to 1x if I remember to change the file first.
I was also able to implement the 1-line change in the PR mentioned above (#1013) which works perfectly, and it would be nice to see this added to the main branches.

@IMS212
Copy link
Member

IMS212 commented Oct 24, 2022

This was fixed in 0.4.3.

@IMS212 IMS212 closed this as completed Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-enhancement Type: Enhancement