Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore undersized quads #2060

Merged
merged 1 commit into from Sep 18, 2023
Merged

Conversation

embeddedt
Copy link
Contributor

Some mods provide baked quads with less than 32 entries in vertexData. Sodium doesn't do range checks and assumes all quads have at least 32 entries, causing crashes with these mods. We cannot render anything logical with this information but we can at least skip the bad quads entirely, preventing the crash.

@jellysquid3 jellysquid3 added this to the Sodium 0.5.3 milestone Sep 6, 2023
@IMS212 IMS212 merged commit 42bb21e into CaffeineMC:dev Sep 18, 2023
1 check passed
@embeddedt embeddedt deleted the ignore-undersized-quads branch October 13, 2023 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants