Show sha1 when hovering over a line in the blame view

caged · Oct 6, 2008 · 2915656 · 2915656
1 parent 453ea66
commit 2915656
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 4 deletions.
diff --git a/assets/style.css b/assets/style.css
@@ -236,6 +236,23 @@ h2#place-holder {
   padding: 5px;
 }
 
+#blame .sha {
+  position: absolute;
+  background-color: #000;
+  color: #ccc;
+  -webkit-border-radius: 4px;
+  padding: 2px;
+  line-height: 120%;
+  opacity: 0.7;
+  top: 3px;
+  right: 0;
+  display: none;
+}
+
+#blame li:hover .sha {
+  display: inline;
+}
+
 .image-wrapper {
   vertical-align: middle;
   height: 100%;

diff --git a/controllers/CommitsController.rb b/controllers/CommitsController.rb
@@ -14,8 +14,8 @@
 
 def gravatar_url(email, size=36, default="x-img://default")
   hash = MD5.hexdigest(email.downcase)
-  edefault = default.gsub(/[^a-zA-Z0-9_-]/) { |s| "%%%02X" % s[0]}
-  NSURL.URLWithString("http://www.gravatar.com/avatar.php?gravatar_id=#{hash}&s=#{size}&d=#{edefault}")
+  default.gsub!(/[^a-zA-Z0-9_-]/) { |s| "%%%02X" % s[0]}
+  NSURL.URLWithString("http://www.gravatar.com/avatar.php?gravatar_id=#{hash}&s=#{size}&d=#{default}")
 end
 
 class CommitsController < OSX::NSObject

diff --git a/controllers/TreeController.rb b/controllers/TreeController.rb
@@ -30,6 +30,7 @@ def awakeFromNib
     @tree_outline.setDataSource(dsource)
     @tree_outline.setDelegate(dsource)
     @tree_outline.expandItem(@tree_outline.itemAtRow(0))
+
   	NSNotificationCenter.defaultCenter.objc_send(:addObserver, self,
   		:selector, :item_was_selected,
   		:name, "NSOutlineViewSelectionDidChangeNotification",
@@ -76,11 +77,11 @@ def item_was_selected(notification)
               line = line.empty? ? "&nbsp;" : line.escapeHTML
               li = doc.createElement('li')
               img = doc.createElement('img')
-              url = gravatar_url(commit.author.email, 16).to_s
+              url = gravatar_url(commit.author.email, 16, '').to_s
               img.setAttribute__('src', url)
               img.setAttribute__('class', 'gravatar')
               img.setAttribute__('title', commit.author.email)
-              li.setInnerHTML(%(<span class="linenum">#{i}</span><pre><code>#{line.chomp}</code></pre>))
+              li.setInnerHTML(%(<span class="linenum">#{i}</span><span class="sha">#{commit.sha}</span><pre><code>#{line.chomp}</code></pre>))
               li.appendChild(img)
               blame_list.appendChild(li)
               i += 1