Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with 'favicon'? #597

Closed
giabaio opened this issue May 1, 2022 · 7 comments
Closed

Issues with 'favicon'? #597

giabaio opened this issue May 1, 2022 · 7 comments

Comments

@giabaio
Copy link

giabaio commented May 1, 2022

Hi there. I am not sure this is the right place to ask these couple of questions - I hope so...

So: I've just started using this theme, which looks very nice, simple and flexible. I have experienced a couple of issues with the favicon, though. Firstly I was trying to use an image in assets/img (locally, not under themes/hugo-theme-stack/) and it wasn't working. I figured that there's some processing of the images to rescale them and, while doing this, the file got renamed - I think that pointing to the renamed file in my config.yaml file did the trick.

However, it seems like this is only working for the landing page. Any other page doesn't show the favicon. An example is here.

Am I missing something obvious? I've not changed much form the default theme --- only added a few lines to layouts/partials/article/components/details.html (which I have created a copy of under the root of my website) to show the authors of each post.

Thanks in advance.
Gianluca

@rmdhnreza
Copy link
Contributor

Place icon locally under static/favicon.ico folder (assuming your icon named as favicon.ico).
In config.yaml set like this.

params:
    favicon: /favicon.ico

@giabaio
Copy link
Author

giabaio commented May 3, 2022 via email

@Ayx03
Copy link

Ayx03 commented May 7, 2022

Place icon locally under static/favicon.ico folder (assuming your icon named as favicon.ico). In config.yaml set like this.

params:
    favicon: /favicon.ico

I used to do this, which doesn't work properly as well. Thanks for your solution @rmdhnreza.

params:
    favicon: favicon.jpg

@etsea117
Copy link

etsea117 commented Jun 2, 2022

I am still having trouble viewing the favicon after doing it this way @rmdhnreza . Is there anything I need to adjust in the theme that might be overriding it?

@Ayx03
Copy link

Ayx03 commented Jun 2, 2022

I am still having trouble viewing the favicon after doing it this way @rmdhnreza . Is there anything I need to adjust in the theme that might be overriding it?

Would you provide your config file along with folder structure? Also try deleting /resource and /public then re generate them

@etsea117
Copy link

etsea117 commented Jun 2, 2022

@Ayx03 I ended up fixing it. I had the favicon.ico in the /static folder by itself originally. I changed it to have it in /static/img/ instead and that worked.

@CaiJimmy
Copy link
Owner

CaiJimmy commented Jun 5, 2022

Seems to be confusing this part of the configuration. Will consider refactoring this part.

Thanks for your responses!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants