Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shortcodes): add quote shortcode, and example #414

Merged
merged 5 commits into from
Jun 8, 2022

Conversation

tesujimath
Copy link
Contributor

No description provided.

@CaiJimmy CaiJimmy changed the title Add quote shortcode, and example feat(shortcodes): add quote shortcode, and example Jan 23, 2022
@CaiJimmy CaiJimmy added the feature New feature or request label Jan 23, 2022
@tesujimath
Copy link
Contributor Author

@CaiJimmy Sorry for the long time I neglected the merge conflict. Fixed now.

If you're not keen on merging this, please say, and I will close the PR and simply include it in my site layouts. Personally I use it a lot, and thought others may also appreciate it.

@CaiJimmy
Copy link
Owner

@CaiJimmy Sorry for the long time I neglected the merge conflict. Fixed now.

If you're not keen on merging this, please say, and I will close the PR and simply include it in my site layouts. Personally I use it a lot, and thought others may also appreciate it.

No need to apologize. I am the one who should apologize for leaving this so long without processing it.

Once I finish with my course I'll take a look at this ASAP.

Thanks for your patience and help 🙏

@tesujimath
Copy link
Contributor Author

👍

This style is only used on the article page, so it makes more sense to have it there.
@CaiJimmy
Copy link
Owner

CaiJimmy commented Jun 8, 2022

Thanks!

I've done some modifications (moving quote.scss into article.scss). This style is only used on the article page, so it makes more sense to have it there.

Sorry again for taking so long.

@CaiJimmy CaiJimmy merged commit 955bb8d into CaiJimmy:master Jun 8, 2022
@tesujimath
Copy link
Contributor Author

Thanks, all good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants