[LP1943052] wayland-manager: allocate new wl_output information by checking id #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecking id With KDE Plasma Wayland session, after calling wl_output_add_listener() and waiting for wl_output information with wl_display_roundtrip(), wl_output::mode info is returned before wl_output::geometry info. Current cairo-dock-wayland-manager logic expects the opposite order, and on KDE session this causes cairo-dock segfault. To avoid this, when collecting wl_output information, we should also check "id" member of global registry object associated with that wl_output info, check if the "id" is already the duplicates of the old infos. Then if the "id" is new one, then allocate the new buffer to register new wl_output information beforehand, then call wl_display_roundtrip() to gain wl_output::geometry or wl_output::output information.
|
How do I do that? |
|
Maybe I should switch to the |
|
Hi, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With KDE Plasma Wayland session, after calling wl_output_add_listener()
and waiting for wl_output information with wl_display_roundtrip(),
wl_output::mode info is returned before wl_output::geometry info.
Current cairo-dock-wayland-manager logic expects the opposite order, and
on KDE session this causes cairo-dock segfault.
To avoid this, when collecting wl_output information, we should also check
"id" member of global registry object associated with that wl_output info,
check if the "id" is already the duplicates of the old infos.
Then if the "id" is new one, then allocate the new buffer to register new
wl_output information beforehand, then call wl_display_roundtrip() to gain
wl_output::geometry or wl_output::output information.
Should fix https://bugs.launchpad.net/cairo-dock-core/+bug/1943052