Use new CakeObject instead of reserved Object class #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves PHP 7 compatibility.
|
The Travis jobs fail, because this change is only compatible with CakePHP 2.9.0+. |
|
Bumped CakePHP version in Travis jobs to 2.9. Succeeds now. |
|
Successfully tested in one of my applications. |
|
This PR cakephp/cakephp#9510 is probably the better solution, as it does not bump the minimum requirements for the plugin... |
|
I agree, let's wait for the next stable release 2.9.x as this would keep the plugin as much BC as possible. Thank you @ravage84 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #274