This repository has been archived by the owner on Oct 20, 2023. It is now read-only.
Issue #147 fix for Unit Tests fail if SoftDelete Behavior is attached. #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug was first described in #138. Was partially fixed in #139. But the fix is incomplete, and also breaks relationships that use aliases (described in #147).
With the proposed changes, the behavior will not become active if the table is missing, and -thus- will not attempt to run $model->hasField($flag), responsible for the MissingTableExceptions. The only scenario in which I believe this missing table issue happens is in unit testing, when relationships are loaded before fixtures. This fix should not affect normal operation.