Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move good_dimindex_def to a common file #818

Closed
hirataqdees opened this issue Mar 12, 2021 · 0 comments
Closed

Move good_dimindex_def to a common file #818

hirataqdees opened this issue Mar 12, 2021 · 0 comments

Comments

@hirataqdees
Copy link
Member

good_dimindex is defined in labPropsScript.sml. This makes its usage elsewhere dependent on labPropsTheory and hence also the frontend files. It would be best to move the definition and related theorems to a common file, lets say miscScript.

IlmariReissumies added a commit that referenced this issue Mar 14, 2023
good_dimindex is needed here and there. It seems silly to pollute
the dependency graph with imports of labProps just for that.

Fixes issue #818.
mktnk3 pushed a commit to mktnk3/cakeml that referenced this issue May 10, 2023
good_dimindex is needed here and there. It seems silly to pollute
the dependency graph with imports of labProps just for that.

Fixes issue CakeML#818.
mktnk3 pushed a commit that referenced this issue May 10, 2023
good_dimindex is needed here and there. It seems silly to pollute
the dependency graph with imports of labProps just for that.

Fixes issue #818.
xdrr pushed a commit to xdrr/cakeml that referenced this issue Jul 8, 2023
good_dimindex is needed here and there. It seems silly to pollute
the dependency graph with imports of labProps just for that.

Fixes issue CakeML#818.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants