Simplify handle_mult using Pvar pattern #423
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
regression test is failing - reopen on fix |
|
I don't know why 146 failed. Running the regression test again to see if it fails again. |
|
Is this still work-in-progress, or ready for merge? |
|
It was meant to be ready for merge.
…On Fri, 12 Jan 2018 at 08:12, Ramana Kumar ***@***.***> wrote:
Is this still work-in-progress, or ready for merge?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#423 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AA8739zHqUYyYzqffMcxCl_K39oAvN5pks5tJnkWgaJpZM4RV4vF>
.
|
|
This is consistently failing the regression test in a mysterious way. I'm closing it for now - reopen when/if someone can confirm that the failing directory actually succeeds. I can produce a tarball of the regression test worker's state if desired. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.