Add header file for compcert compatibility #604
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, compiling
basis_ffi.c
with compcert (the newest release, version 3.4) results in the following error "use of undeclared identifier 'S_IRUSR'". This macro, along with the other mode arguments for open(), are defined insys/stat.h
. Including this header resolves the issue.I'm not sure why this isn't a problem when compiling under gcc. I assume one of the other header files includes
sys/stat.h
, but I was also under the assumption that both compcert and gcc would use the same system-provided header files. Regardless, the linux man page for open() seems to suggest includingsys/stat.h
(as well assys/types.h
, although this was not necessary on my machine), so including these may be wise for portability reasons.