Eval type rep #845
Merged
Eval type rep #845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition to the type-representation invariants (e.g. LIST_TYPE), the translator now also defines type-representation functions which map to the v type, for any type for which it could previously prove EqualityType. This is needed in the Eval proofs to represent the config oracle as a sequence of v values, to avoid further type parameters.
Eliminate some precond conjuncts of equality lemmas that can be proven from other equality lemmas when they are added to the store. This saves some repeated work later.
This one doesn't use measures, and could in principle work with mutually recursive datatypes (which don't seem to be supported elsewhere in the translator).
Function types passed to datatype constructors mean that EqualityType and IsTypeRep are (probably) impossible. However, the provers now handle these datatypes normally, although the saved theorems have (probably) impossible preconditions.
Instead of hand-adding a workaround for the function type, the code patches in a dummy representation for any unknown types, with various plumbing changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the "type representation" feature that will eventually be needed by Eval.
It also cleans up the EqualityType proof code a fair bit.
This PR is mostly for testing, there's no need for this feature in master for the time being.