Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set language to English (UK) automatically #9

Merged
merged 2 commits into from
Jun 11, 2019
Merged

Set language to English (UK) automatically #9

merged 2 commits into from
Jun 11, 2019

Conversation

schmijos
Copy link
Contributor

Since I've set my Facebook language to German, this got me (even though you pointed it out in the readme). So I thought: Let's change the language anyways to make the tool more usable.

@Calamari
Copy link
Owner

I personally like the idea of letting it run more smoothly in removing known obstacles, but always changing it to english is a bit weird, because people would then not know what had happened to their FB.
Can I suggest to check if the language is already the right one, and if not then prompt the user, if he is ok with us changing the language?
Checking if the language is UK english should be easy, I noticed that in the footer the logout link differes in UK ("Log Out") and US ("logout").

What do you think @schmijos?

@schmijos
Copy link
Contributor Author

schmijos commented May 7, 2018

Hi @Calamari

I agree with your proposal. Checking the language (and eventually setting it back) would be the nice solution. Nevertheless I just propose you the easier change for now with my newest commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants