Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit test for get_forms() is counting forms included via filter since 1.8.10 #3486

Open
New0 opened this issue Feb 11, 2020 · 0 comments
Open

Unit test for get_forms() is counting forms included via filter since 1.8.10 #3486

New0 opened this issue Feb 11, 2020 · 0 comments
Labels
Needs Research
Milestone
1.9.5

Comments

@New0
Copy link
Collaborator

New0 commented Feb 11, 2020

Tests at tests/Integration/Service/FormServiceTest.php are now counting 5 forms instead of the 2 added in the tests. This makes sense as in 1.8.10 fixes an issue that made the count of forms not updated in get_forms() just after ceate_forms() - #3455 -
That need to be worked on in the clear up function or identified as an issue in delete_forms()
@New0 New0 added this to the 1.8.11 milestone Feb 11, 2020
New0 added a commit that referenced this issue Feb 11, 2020
@New0
Update test and comment it to be reviwed via #3486
df78f29
@New0 New0 modified the milestones: 1.8.11, 1.8.12 Mar 4, 2020
@New0 New0 modified the milestones: 1.8.12, 1.9.1, 1.9.2 Jun 18, 2020
@New0 New0 modified the milestones: 1.9.2, 1.9.3 Jul 15, 2020
@New0 New0 modified the milestones: 1.9.3, 1.9.5 Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs Research
Projects
None yet
Milestone
1.9.5
Development

No branches or pull requests
1 participant
@New0