Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset correct code used by Translaton file #3111

Merged
merged 1 commit into from Mar 21, 2019
Merged

Reset correct code used by Translaton file #3111

merged 1 commit into from Mar 21, 2019

Conversation

New0
Copy link
Collaborator

@New0 New0 commented Mar 21, 2019

$code don't set correctly before running window.Parsley.setLocale('$code')

function get_validator_locale_url() , created in 1.8.3,made $code not to be available in maybe_validator_i18n(), which runs window.Parsley.setLocale('$code')

created set_locale_code(); tfrom the condition within get_validator_locale_url() to be reused in maybe_validator_i18n()

That fixes #3106

Code don't set correctly before running window.Parsley.setLocale('$code')
@New0 New0 added the PR (Patch) Is a pull request label Mar 21, 2019
@New0 New0 added this to the 1.8.4 milestone Mar 21, 2019
@New0 New0 self-assigned this Mar 21, 2019
@New0 New0 requested a review from Shelob9 March 21, 2019 16:17
Copy link
Collaborator

@Shelob9 Shelob9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is exactly what I would have done. Using that sometimes set static variable directly was messy. I like that this puts a wrapper around it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR (Patch) Is a pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants