State managment for entries #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 28, 2018 19:12
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -0,0 +1,18 @@ | |||
| export const SET_ENTRIES = 'SET_ENTRIES'; | |||
There was a problem hiding this comment.
Definition for rule 'jest/prefer-to-have-length' was not found
src/state/actions.entries.js
Outdated
| formId, | ||
| pageNumber, | ||
| entries | ||
| } |
src/state/actions.entries.js
Outdated
| pageNumber, | ||
| entries | ||
| } | ||
| } |
Pull Request Test Coverage Report for Build 30
💛 - Coveralls |
| * @param {Object} state Collection of entries, by form Id and page | ||
| * @return {*} | ||
| */ | ||
| export const getPageOfEntries = (formId,pageNumber,state) =>{ |
There was a problem hiding this comment.
Definition for rule 'jest/prefer-to-have-length' was not found
src/tests/selectors.test.js
Outdated
| @@ -20,6 +20,8 @@ import { | |||
| getStyleIncludes, | |||
| getOtherSettings | |||
| } from "../state/selectors.settings"; | |||
| import {entriesReducer} from "../state/reducers"; | |||
There was a problem hiding this comment.
'entriesReducer' is defined but never used.
| } | ||
| } | ||
|
|
||
| ) ).toEqual( {a:1}) |
| } | ||
|
|
||
| ) ).toEqual([]); | ||
| }) |
added 2 commits
August 1, 2018 19:46
| @@ -1,5 +1,8 @@ | |||
| import * as calderaState from '../state/module'; | |||
| import {closeStatus, startSpinner, stopSpinner, updateStatus} from "../state/actions.status"; | |||
| import {setEntries} from "../state/actions.entries"; | |||
| import {getPageOfEntries} from "../state/selectors.entries"; | |||
There was a problem hiding this comment.
'getPageOfEntries' is defined but never used.
| @@ -1,5 +1,8 @@ | |||
| import * as calderaState from '../state/module'; | |||
| import {closeStatus, startSpinner, stopSpinner, updateStatus} from "../state/actions.status"; | |||
| import {setEntries} from "../state/actions.entries"; | |||
| import {getPageOfEntries} from "../state/selectors.entries"; | |||
| import {CALDERA_FORMS_ENTRIES_SLUG} from "../state"; | |||
There was a problem hiding this comment.
'CALDERA_FORMS_ENTRIES_SLUG' is defined but never used.
|
Code Climate has analyzed commit f883cf8 and detected 6 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7