Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all spaces/format chars from data files #60

Closed
wants to merge 1 commit into from

Conversation

danieldjewell
Copy link

The use of spaces and/or other punctuation in filenames has been
problematic for years. Even though modern OSes (usually) handle it
somewhat OK, that can't be assumed. Older OSes (especially big *NIXes)
could be especially problematic.

This renames all data files in the thermo/ directory to use underscores
instead of spaces, removes (), and changes "-" to a single underscore.
References to the files are also updated.

I ran the test suite and the results are the same pre/post. (Some of the
tests failed on a clean copy of master -- is the test suite 100%?)

The use of spaces and/or other punctuation in filenames has been
problematic for years. Even though modern OSes (usually) handle it
somewhat OK, that can't be assumed. Older OSes (especially big *NIXes)
could be especially problematic.

This renames all data files in the thermo/ directory to use underscores
instead of spaces, removes (), and changes "_-_" to a single underscore.
References to the files are also updated.

I ran the test suite and the results are the same pre/post. (Some of the
    tests failed on a clean copy of master -- is the test suite 100%?)
@coveralls
Copy link

coveralls commented Aug 31, 2020

Coverage Status

Coverage remained the same at 88.852% when pulling b49d3aa on danieldjewell:death_to_0x20 into 9f4175a on CalebBell:master.

@CalebBell
Copy link
Owner

Hi Daniel,

Escape characters for spaces have been supported on every popular OS for longer than I have been alive; tab-completion on pretty much any shell will add them for you. You could equally say unicode characters are an issue in the Python files themselves, to which I would say, upgrade your Python/OS.

I appreciate that you want to improve thermo, but it looks like work for no benefit to me. Is there a particular issue you are having I am unaware of?

Sincerely,
Caleb

@CalebBell CalebBell closed this Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants