Add new context menu items #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CalebJohn
reviewed
Dec 28, 2021
|
Thanks for the changes @laurent22! This is really cool, I saw the commits updating the plugin API for this the other day and I started scheming to add this myself. It's nice of you to beat me to it! I'm going to wait for 2.7 before merging this. I don't plan on making any changes to the plugin before then, so there shouldn't be any merge conflicts with this branch. |
|
Thanks again @laurent22! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements the change that was discussed there and makes use of the new
joplin.workspace.filterEditorContextMenuwhich allows dynamically setting items depending on the context. Using this and other new plugin APIs I've added the same menu items as in the preview - "Open link", "Reveal in folder" and "Copy path to clipboard" when right clicking on a resource.I've also added "Toggle checkbox" for checkboxes.
The plugin requires the desktop app v2.7, which is not yet released!
I had to refactor the code a bit in ClickHandler to allow retrieving the type of content under the cursor. I think the code is equivalent but let me know if you prefer to do this differently.
Actual changes start here (the rest is just an update to the plugin API)