Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeMirror 6: Fix header token position and image fade-in #59

Conversation

personalizedrefrigerator
Copy link
Contributor

@personalizedrefrigerator personalizedrefrigerator commented Feb 20, 2024

Summary

This is a follow-up pull request to #58. It fixes issues related to the stylish theme and focus mode.

More specifically, it does the following:

  • Corrects the position of # characters in headings in the stylish theme in CodeMirror 6.
  • Corrects the opacity of img tags just below the active line.
  • Removes reliance on .CodeMirror-line selectors (allowing them to be removed from the upstream pull request)
    • The upstream pull request had previously added the CodeMirror-line class to each visible line.

Screenshots

CodeMirror 5:
screenshot: CodeMirror 5 editor with rich markdown

CodeMirror 6:
screenshot: CodeMirror 6 editor with rich markdown

@CalebJohn CalebJohn merged commit 94a5d2e into CalebJohn:main Feb 22, 2024
@CalebJohn
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants